Properly support mmol/L in the status extension. #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the raw HKUnit.unitString (eg. mmol<180.1558800000541>/L) through the context, as opposed to the unitDisplayString which is uses the glucose-centric version (eg. mmol/L). This way we can properly hydrate the unit on the extension side and represent it in the extension. Fixes LoopKit#311.
loudnate
approved these changes
Dec 11, 2016
|
|
||
| if let glucose = latestGlucose, | ||
| preferredUnitDisplayString != nil { | ||
| preferredUnitString != nil { |
Author
There was a problem hiding this comment.
It may not be necessary, but it's a safeguard against the possibility that we have glucose quantity and start date, but an improperly set preferred unit string. In that case, I'd rather send no glucose data than send it in the absence of a unit string. Happy to remove / adjust it if you see a better way.
Collaborator
There was a problem hiding this comment.
OK - reversing the order of the conditions would make that clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the raw HKUnit.unitString (eg. mmol<180.1558800000541>/L) through
the context, as opposed to the unitDisplayString which is uses the
glucose-centric version (eg. mmol/L). This way we can properly hydrate
the unit on the extension side and represent it in the extension.
Fixes #311.