-
Notifications
You must be signed in to change notification settings - Fork 1.4k
ios26 fixes #2371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios26 fixes #2371
Conversation
TestUse LoopWorkspace branch release/3.8.2 which is being prepared for release soon. Configuration: For iOS 26:
For iOS 18:
Use the same test table as from Issue #2360. Each row in the table was tested with this version of iOS 26 and iOS 18 phones.
The indication 2️⃣ is a different failure, see Issue #2267 - this issue is not fixed and only affects SE phones. I don't have a non-SE iOS 26 phone to test, but the therapy settings do get updated just not reflected in therapy settings screen right away and the fact that items that are marked ❌ before and are marked ✅2️⃣ counts as a fix for me. Example of a 2️⃣ is given below for basal rate:
Test Table | Therapy Setting | initial | final | yellow/red | iOS 26 | iOS 18 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve based on test. See #2371 (comment) which indicates failures described in #2360 are fixed.
I don't have an example where the inactive button was not grey and where information views auto-dismissed, so I can't demonstrate these are fixed. But willing to approve and accept this change without that test.
I did test all three fixes as reported in comments below.
Test Part 2The dismissing info views is fixed with this PR. "If you tap on the little info icon on any setting, the screen would dismiss in a second or so, automatically."
|
Test Part 3The "DIsabled actions buttons should look disabled" is fixed with this pair of PRs Extra information:
I tested the buttons with this PR with LoopKit PR 573
I then restored to the version without Loop PR 2371 / LoopKit PR 573
|
Along with the changes in LoopKit/LoopKit#573, this has the following fixes:
Should fix #2360