Skip to content

Conversation

@ps2
Copy link
Collaborator

@ps2 ps2 commented Oct 20, 2025

Along with the changes in LoopKit/LoopKit#573, this has the following fixes:

  • DIsabled actions buttons look disabled
  • Information views do not auto-dismiss
  • Saving values in warning ranges works again

Should fix #2360

@ps2 ps2 requested review from itsmojo and marionbarker October 20, 2025 23:05
@marionbarker
Copy link
Contributor

Test

Use LoopWorkspace branch release/3.8.2 which is being prepared for release soon.
For Loop and LoopKit, modify to use branch ps2/ios26-fixes for each.

Configuration:

For iOS 26:

  • SE 3rd gen phone running iOS 26.0.1
  • CGM Nightscout
  • Pump Simulator

For iOS 18:

  • SE 2nd gen phone running iOS 18.7.1
  • CGM Nightscout
  • Pump Simulator

Use the same test table as from Issue #2360.

Each row in the table was tested with this version of iOS 26 and iOS 18 phones.

  • The ✅ indicates nominal behavior that used to have an ❌.
  • The word "ok" indicates it was nominal in the table from Issue 2360 and still nominal with this test
  • The indication ✅2️⃣ indicates an SE specific failing that is still present with iOS 26 but now the change in therapy takes place as expected

The indication 2️⃣ is a different failure, see Issue #2267 - this issue is not fixed and only affects SE phones. I don't have a non-SE iOS 26 phone to test, but the therapy settings do get updated just not reflected in therapy settings screen right away and the fact that items that are marked ❌ before and are marked ✅2️⃣ counts as a fix for me. Example of a 2️⃣ is given below for basal rate:

  • Modify basal rate, authenticate and the Therapy screen is shown with the old basal rate
  • Return to main screen and then return to the Therapy screen
  • Observe that the new basal rate is now shown
  • Note that this issue is specific to SE phones for iOS 18 (and is seen for iOS 26)

Test Table

| Therapy Setting | initial | final | yellow/red | iOS 26 | iOS 18 |
|:--|:--|:--|:-:|:-:|:-:|:-:|
| Glucose Safety | 70 | 75 | n | ok | ok |
| Glucose Safety | 75 | 70 | y | ✅ | ok |
| Target | 100-120 | 100-110 | n | ok | ok |
| Target | 100-110 | 100-120 | y | ✅ | ok |
| Carb Ratio | 8 | 30 | y | ✅ | ok |
| Carb Ratio | 30 | 8 | n | ok | ok |
| Basal Rate | 0.5 | 0.65 | n/a | 2️⃣ | 2️⃣ |
| Max Basal | 4 | 5 | y | ✅2️⃣ | 2️⃣ |
| Max Bolus | 8 | 20 | y | ✅2️⃣ | 2️⃣ |
| ISF | 50 | 10 | y | ✅ | ok |
| ISF | 10 | 50 | n | ok | ok |

Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve based on test. See #2371 (comment) which indicates failures described in #2360 are fixed.

I don't have an example where the inactive button was not grey and where information views auto-dismissed, so I can't demonstrate these are fixed. But willing to approve and accept this change without that test.

I did test all three fixes as reported in comments below.

@marionbarker
Copy link
Contributor

Test Part 2

The dismissing info views is fixed with this PR.

"If you tap on the little info icon on any setting, the screen would dismiss in a second or so, automatically."

  • Test with the code in this PR on iOS 26 phone - this does not happen
  • Load version 3.9.1 from TestFlight onto the iOS phone - observe this behavior

@marionbarker
Copy link
Contributor

Test Part 3

The "DIsabled actions buttons should look disabled" is fixed with this pair of PRs

Extra information:

If you would go to edit any therapy but hadn't changed anything, the button would be blue, like it could be clicked on.

I tested the buttons with this PR with LoopKit PR 573

  • Therapy, Carb entry, Bolus entry, etc - all buttons behavior appeared nominal, grey when inactive, blue when active

I then restored to the version without Loop PR 2371 / LoopKit PR 573

  • Therapy save buttons were blue all the time, even when no change had been made and thus they were actually inactive

@marionbarker marionbarker merged commit 7c94007 into dev Oct 21, 2025
@ps2 ps2 deleted the ps2/ios26-fixes branch October 23, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some issues saving therapy settings with iOS 26

3 participants