Update meal label, proposed remedy for Issue #2168

[marionbarker]

Purpose:

Provide a different label for the button when saving carbs and bolusing to make it more obvious that tapping the button saves the carbs.

Associated Issue

See Issue #2168 for explanation.

Not understanding that carbs are saved even if bolus is not successful is a problem experienced by many new loopers and often by new caregivers for younger loopers.

[marionbarker]

Test

Apply this modification to LoopWorkspace dev, commit 3d48a5c, Loop dev, commit 760174b.
The screenshot below is from an iPhone 8 running iOS 16.7.10
The left side was built with unmodified dev, the right side was modified by this PR.
Updated to match the PR with commit 9980ed6f

[marionbarker]

I reviewed the screens that are shown to the user after tapping the Save and Deliver button if there is an error with the delivery:

• User enters carbs
• User accepts recommended bolus
• Next screen shows a bolus failure - these screens are independent of whether the bolus is arrived at as part of a meal, manual bolus or auto-bolus.
• Left to right:
  • unacknowledged command
  • failure to find the pod
  • bolus in progress

[marionbarker]

Status

I suggest this button change be accepted for now with potential updates coming at a later time.

• Final wording on the button is "Save Carbs & Deliver"

Discussion

I had a discussion with some Tidepool folks:

• They were concerned that the button change alone would not be sufficient to solve Avoid unnoticed carb entries #2168
• I agreed to explore adding messages that indicated that "If carbs were added, they were saved"
  • After looking into this, my suggestion is to just make the button change for now

There are 2 places where added messages can happen

• Uncertain comms modal alert
• Bolus Issue alert

One negative of this approach is the carbs saved message would be displayed for any bolus or uncertain comms issues.

Option: Modify uncertain comms modal message

If I implemented this, it could look like the graphic below, where the new text is underlined to make it easy to find.

Option: Add to the Bolus Issue alerts

Default screens are seen in the previous comment for some Bolus Issue alerts.

• I tried adding the sentence to the alert in the body of the message but the message truncates and important information is lost
• I then tried modifying the title of the alert, i.e., alert title changed to "Bolus Issue (Carbs Saved)" and was not convinced and even this is truncated with larger text sizes

[ps2]

We'll have to back this out for a merge back to Tidepool, but I'm ok to land this for DIY for now.