Skip to content

Backport cyclic dependency fixes from dev for building on Xcode 15 #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2023
Merged

Backport cyclic dependency fixes from dev for building on Xcode 15 #2069

merged 2 commits into from
Sep 19, 2023

Conversation

@ps2
Copy link
Collaborator

@ps2 ps2 commented Sep 19, 2023

No description provided.

@marionbarker
Copy link
Contributor

marionbarker commented Sep 19, 2023

Code review nominal.

  • Scripts/capture-build-details.sh is slightly different between dev and xcode-15-main.

Tests:

  • builds onto iOS 17 phone with Xcode 15 as 3.2.3.
  • builds onto iOS 16 phone with Xcode 15 as 3.2.3.
  • builds onto iOS 15 phone with Xcode 15 as 3.2.3.

@ps2 ps2 merged commit c6b058b into main Sep 19, 2023
@ps2 ps2 deleted the xcode-15-main branch September 19, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ps2 @marionbarker