Rename flag for disabling remote commands #1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build flag for disabling remote commands is misleading -- REMOTE_OVERRIDES_DISABLED -- as it more generally is used for disabling all commands (bolus and carbs).
This PR will rename the flag to REMOTE_COMMANDS_DISABLED while continuing to support the old flag so users are not opted-into remote commands with this change.
Testing
I did some checks that building with both REMOTE_OVERRIDES_DISABLED and REMOTE_COMMANDS_DISABLED set disables remote commands.