Tidepool merge #1850
Merged
Tidepool merge #1850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs-fixes LOOP-4211 Therapy settings fixes
* initial pass at adding go to settings button in the critical alert modal * remove foreground content from the riskMitigationAlert, since it is handle by the AlertManager * added placeholder text for the alert premissions disabled banner * add dismiss button to alert permissions disabled warning * acknowledge alert with close option * response to PR comments * clean up * more cleanup * updated notification permissions banner * updated style of alert permission disabled alert * copy update
* issue notification permission alert when in background and retract in-app alert as needed * remove unused code * response to PR comments
* added placeholder UI to configure mute alerts duration * checkpoint * checkpoint * initial commit at the alert muter * minor clean-up * removed unused file from project * corrected predicate syntax * all alerts at least vibrate * checkpoint * insteadOf = https://github.com/ updating unit tests * checkpoint * tighter coupling between alert manager and in-app/user notification alert issuers * corrected rescheduling loop not running notifications and use timers for UI * make the mute end period timer internval to the alert muter * corrected typo * updated unit tests * added duration to temp mute alerts setting * minor clean-up * using source of truth for last loop date * renamed Issuer -> Scheduler for in-app and user notification
* corrected identifier for loop not looping notifications * updated test to run for both DIY and Tidepool
* Prevent marking onboarding as finished when pausing * Update comment for clarity
* updated copy of time alert * using device model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Fix settings reset issue
BUG: When user has manually changed device time back over 30min, the Time Change Detected message does not repeat properly
BUG: User can complete onboarding with Correction Range below the Glucose Safety Limit
Critical alert modal and banner update
Notification banners re-enabled
Fix crash in ZipArchiveTests
Pump/CGM status highlight alignment fixes
Temporary mute critical alerts (wip - disabled in DIY)
Orientation change issues on iOS 16 fixed (Unable to change orientation to Landscape after delivering a bolus)