Missed a few casts during Swift 3 migration #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps2
pushed a commit
that referenced
this pull request
Aug 4, 2020
* Initial rough sketch of new bolus screen * Fix keyboard interaction, add recommendation changed alert * Refactoring & cleanup * Compute active carbs even when glucose is stale * Ensure UI is fixed after action is initiated * Support pop back on carb entry edit * Replace BolusViewController entirely * Allow drag-to-dismiss for correction bolus * Alerts for edge cases * Ensure all state updates happen within the same `getLoopState` * Add notices for no bolus rec and stale glucose * Fix indentation * Initial manual glucose entry guts * Begin editing manual glucose field immediately * PR feedback * Predict glucose from manual glucose * Recommend bolus for manual glucose entry * Observe elapsed time; cleanup * Support CGM coming back online * Minor cleanup * Updates from review * Clean up branching around optional effects * Updates from review * Update from color changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.