Tidepool merge #1553
Merged
Tidepool merge #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds variation for COB display for Compact width screens * Revert unnecessary storyboard mods * Revert unnecessary storyboard mods
* additional handling since LoopSettings is a struct * response to PR comments
* mutate settings for each case * corrected typo
LOOP-3787 Warnings based on glucose input
* Add glucose range restriction, and move max bolus warning earlier * Add carbohydrateEntryTooLarge warning * Cleanup alerts that happened after action button; now showing warnings instead * Reorder enum to be alphabetical
- https://tidepool.atlassian.net/browse/LOOP-3323 - https://tidepool.atlassian.net/browse/LOOP-3538 - https://tidepool.atlassian.net/browse/LOOP-3539 - https://tidepool.atlassian.net/browse/LOOP-3540 - https://tidepool.atlassian.net/browse/LOOP-3541 - https://tidepool.atlassian.net/browse/LOOP-3770 - Allow suspending and resuming onboarding - Display resumed onboarding in modal dialog presentation - Display Complete Setup to pump pill if onboarding not complete and pump not onboarded - Display Complete Setup banner if onboarding not complete and pump onboarded - Only ensure current pump data if pump is onboarded - Refresh device data immediately after CGM or pump onboarded - Do not allow adding carbs via detail view if onboarding not complete - Do not allow changing closed loop state if onboarding not complete - Disable various toolbar items if onboarding not complete - Add ResumeOnboardingProvider - Add IconTitleSubtitleTableViewCell - Fix bug in LoopDataManager where settings were not persisted
…a a separate app (#445)
* allow versions of Loop to use a feature flag to enable debug features * response to PR comment
…449) - https://tidepool.atlassian.net/browse/LOOP-3836 - Check individual onboarding for completion prior to displaying view controller
…e alert stack (#450) * presenter can dismiss an alert not at the top of the alert stack * more consistent naming * response to PR comments
- https://tidepool.atlassian.net/browse/LOOP-3838 - Ensure LoopAppManager launch is not invoked multiple times
Merge Release/v1.1.0 into dev
…ice managers (#453) * ckpt * Show version update in loop icon if allowDebugFeatures * adds unit tests * fix tyop * PR Feedback * More PR feedback
* LOOP-3853: Puts bolus error description into notification body if need be Turns out the issue is that the `errorDescription` from the pump manager was being put into an iOS notification's `subtitle` field, which apparently can only be one line. Thus, if it is too long, it gets ellipsized. At first I just put it into the `body`, but then I thought that this might not be in the spirit of the original implementation, so I made a conservative estimate for the max length that would fit in the subtitle. If it fits, it still puts it there. If it doesn't, it puts it into the body. * Reverts algorithm that was still trying to use subtitle.
* PumpManager protocol changes for syncing * Remove debug prints
…lowSimulators" is true (#459) Also makes the MockPumpManager and MockCGMManager unavailable unless "allowSimulators" is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.