Review changes from trixing/Loop

[trixing]

Hi @ps2 ,

over the last few weeks I have made a few changes to the Loop app in my private branch (https://github.com/trixing/Loop). It's based on an older (~December) LoopKit version. I'd like to rebase, refactor and merge most changes upstream now that this is working reliable (on a base of 1 subject, my kid).

Unfortunately, because I didn't rebase for a while, I'll have to rewrite most of these things from scratch for clean upstream pull requests. As that's going to take a considerable amount of my time, I'd like you to review these changes first and let me know which ones you are likely to accept, or which changes you would want to make it acceptable.

The main features I'd consider for separate pull requests are (for more see the README.md in my branch), in ascending complexity:

1. add maximum Insulin on board setting (Bolus and TempBasal will be limited by this, safety feature for preschool)
2. add minimum Basal Rate (to avoid Ketones, especially interesting for kids as those tend to have low basal rates to begin with. I witnessed extended periods of zero, which would then let to really big highs on carbs afterwards).
3. add a "Note" button on the bottom bar, and to the Carb Entry field (needs a patch to add support in rileylink_ios/NightscoutUploadKit as well)
4. add the possibility to manually enter glucose (in case the sensor is not working) and trigger a Bolus. Also adds a carb-only bolus without any glucose data. Useful because all the data will still be logged to Nightscout and no manual upload is required for these periods.
5. New Bolus logic to include a state machine keeping track of successful delivery (showing state on statusview) and retry.

Screenshots of some of this attached, but best is probably to pull my branch and experiment a bit.

Thanks for all your work setting the base for this!

[ps2]

Wow, these look great! They're all features that have been asked for, and I think we should try to get all of them all in. But yes, separate pull requests would be easier to work with and deal with any needed changes.

[ps2]

Do you need any changes in NightscoutUploadKit to support uploading the notes to NS? I'm getting close to making a release of the RL frameworks, and I can get that in quick if you need.

[trixing]

Yes, but those are not in proper pull request form yet either. Just to set expectations right, I'm going to work on the pull requests over the coming /weeks/ - not days. I mostly wanted to give a heads up to prevent duplicate work and to address possible changes upfront.

…

On Sun, Mar 5, 2017 at 4:12 PM, Pete Schwamb ***@***.***> wrote: Do you need any changes in NightscoutUploadKit to support uploading the notes to NS? I'm getting close to making a release of the RL frameworks, and I can get that in quick if you need. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#390 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE2ao9echPkpnOmjElrYb6WeHtrlY2iks5ritDrgaJpZM4MTbLN> .

-- Jan Dittmer <jdi@l4x.org>, http://l4x.org

[Kdisimone]

@trixing I noticed you don't have the repository anymore? Should I close this issue or are you still working on these features? (pending bolus message is in the recent Loop update)

[trixing]

Correct, I've given up trying to merge them. I have pushed a fork of the code here https://github.com/erikdi/Loop/blob/dev/FEATURES.md for people to try if they want.