Remote Overrides Not Working in Dev

[gestrich]

Describe the bug

Remote overrides do not work in dev. The device token is not being consistently uploaded to Nightscout leading to overrides failing.

To Reproduce

1. Fresh install of Loop dev branch.
2. Enter Nightscout credentials during onboarding.
3. Agree to iOS prompt to allow notifications at end of onboarding.
4. Add a few overrides to Loop and enact one of these overrides locally.
5. Go on Nightscout and attempt to enact another override. An error "Could no find deviceToken in loopSettings".

Expected behavior

It is expected that you can enact overrides from Nightscout after agreeing to the prompt.

Phone

• Hardware: iPhone XS
• OS Version: 14.7.1

Loop Version

• Dev - latest.

[gestrich]

@ps2 Here is a write-up on what appears to be the problem. I can put up a pull request if you like but would like your feedback beforehand.

1. LoopDataManager Currently Expects Device Token to be Persisted: In LoopDataManager.storeSettings(), the deviceToken is overridden by whatever is persisted in LoopSettings. Since LoopSettings doesn't persist the deviceToken, that is always nil. This was discussed in a possible solution in Store device token to LoopSettings #1494. That was declined though since the token should not be persisted per iOS guidelines.
2. NightScout Uploader is Created Lazily: When onboarding, the uploader will be set to nil in its lazy getter. This is not set again until rebooting the app (since lazy). This leads to the upload failing when the notification prompt is agreed to during onboarding.
3. registerForRemoteNotifications() only called during Onboarding: If you are offline during onboarding or setup Nightscout after onboarding, the deviceToken will not be pushed to Nightscout. Nothing seems to trigger registerForRemoteNotifications() later so there doesn't seem to be an opportunity to get the token again. Also, the token may change as discussed in the PR 1494, so it seems we need to allow the token to get updated. didFinishLaunchingWithOptions may be the place to put it per StackOverflow.

[gestrich]

Here's how I'm handling these various issues in the remote bolus branch for now LoopKit/LoopWorkspace@17bb9b6

• For number 1, I am using the token that gets fetched, rather than the token persisted at LoopSettings. Number 3 also helps with this to make sure we always fetch the token on startup. I did review Pete's suggested solutions in PR Store device token to LoopSettings #1494 but I think this change handles those same concerns.
• For number 2, I removed the lazy getter. Instead I update the Nightscout uploader when the api key and url are set. This can be improved more by hooking into the flow in that class that sets all credentials. but I didn't want to spend a lot of time refactoring the setup of the uploader before any feedback. (Not sure if the case is handled of changing Nightscout credentials without reboot -- only if Settings get submitted when Nightscout service gets setup).
• For number 3, I'm fetching the remote token on startup to ensure we always have a token. This doesn't handle the case of setting up Nightscout after onboarding but would be readily fixed with an app reboot for now.

[avouspierre]

I tried to modify the dev version with PR 1494 + your hack but always the same issue error. I tried to restart NS and re-compile Loop but no change. I seems unable to register the device token. Do I need to do a fresh install ?

[gestrich]

@avouspierre This commit contains the updated solution LoopKit/LoopWorkspace@17bb9b6 Note there are changes to the NightscoutSerivce and Loop projects respectively.

[avouspierre]

Thank a lot @gestrich . The patch is perfect and allows to do remote overrides with NS

[blameitonben]

Looking to use this also, but not totally sure how to build with this commit, any help is appreciated. Been missing the remote overrides :) Thanks! Ben

…

________________________________ From: Pierre L ***@***.***> Sent: Sunday, August 29, 2021 7:38:21 AM To: LoopKit/Loop ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [LoopKit/Loop] Remote Overrides Not Working in Dev (#1536) Thank a lot @gestrich<https://www.google.com/url?q=https://github.com/gestrich&source=gmail-imap&ust=1630852702000000&usg=AOvVaw34Ju-M_0OuAOKamYUQ1e4F> . The patch is perfect and allows to do remote overrides with NS — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://www.google.com/url?q=https://github.com/LoopKit/Loop/issues/1536%23issuecomment-907802573&source=gmail-imap&ust=1630852702000000&usg=AOvVaw1u-VeXJVnNXgBGUpErZ7aP>, or unsubscribe<https://www.google.com/url?q=https://github.com/notifications/unsubscribe-auth/ACWNLO5SFUQKEL2LEOXGX6LT7JA53ANCNFSM5DAGF4SQ&source=gmail-imap&ust=1630852702000000&usg=AOvVaw3rPHACkcbtY3euBNRJo2A0>. Triage notifications on the go with GitHub Mobile for iOS<https://www.google.com/url?q=https://apps.apple.com/app/apple-store/id1477376905?ct%3Dnotification-email%26mt%3D8%26pt%3D524675&source=gmail-imap&ust=1630852702000000&usg=AOvVaw0ZyN2jKi0ojbpPo3qMK83U> or Android<https://www.google.com/url?q=https://play.google.com/store/apps/details?id%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&source=gmail-imap&ust=1630852702000000&usg=AOvVaw2rquXXHw2QofKEW5MN8Xoo>.

[Willbumster]

Me too! Sent from my iPhone

…

On Aug 29, 2021, at 5:45 PM, blameitonben ***@***.***> wrote:  Looking to use this also, but not totally sure how to build with this commit, any help is appreciated. Been missing the remote overrides :) Thanks! Ben ________________________________ From: Pierre L ***@***.***> Sent: Sunday, August 29, 2021 7:38:21 AM To: LoopKit/Loop ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [LoopKit/Loop] Remote Overrides Not Working in Dev (#1536) Thank a lot @gestrich<https://www.google.com/url?q=https://github.com/gestrich&source=gmail-imap&ust=1630852702000000&usg=AOvVaw34Ju-M_0OuAOKamYUQ1e4F> . The patch is perfect and allows to do remote overrides with NS — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://www.google.com/url?q=https://github.com/LoopKit/Loop/issues/1536%23issuecomment-907802573&source=gmail-imap&ust=1630852702000000&usg=AOvVaw1u-VeXJVnNXgBGUpErZ7aP>, or unsubscribe<https://www.google.com/url?q=https://github.com/notifications/unsubscribe-auth/ACWNLO5SFUQKEL2LEOXGX6LT7JA53ANCNFSM5DAGF4SQ&source=gmail-imap&ust=1630852702000000&usg=AOvVaw3rPHACkcbtY3euBNRJo2A0>. Triage notifications on the go with GitHub Mobile for iOS<https://www.google.com/url?q=https://apps.apple.com/app/apple-store/id1477376905?ct%3Dnotification-email%26mt%3D8%26pt%3D524675&source=gmail-imap&ust=1630852702000000&usg=AOvVaw0ZyN2jKi0ojbpPo3qMK83U> or Android<https://www.google.com/url?q=https://play.google.com/store/apps/details?id%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&source=gmail-imap&ust=1630852702000000&usg=AOvVaw2rquXXHw2QofKEW5MN8Xoo>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[jonfawcett]

Is this still the only fix for remote overrides in Dev?

Symptoms: remote overrides don't do anything after Dev install. Locally set overrides also do not upload to NS Treatments table so they are not on the NS graph. I'm not sure if both of these are caused by the same issue since I haven't found mentions of the second. I haven't started my own debugging yet to figure out what's going on because I found this old issue.

[Trpl7ca]

I don't use remote overrides, but my local overrides have not been showing up either in NS while using dev or dash-integration.

[gestrich]

I do not think this fixes the issue of overrides not showing on the Nightscout graph (missing the tape). This fix is in the remote bolus branch. I'm not sure of other fixes or what has made it into dev.