LOOP-3871: Make all alerts/notifications "Time Sensitive" (#473)

* checkpoint

* LOOP-3871: Make all alerts/notifications "Time Sensitive"

Also fixes what appears to be a crash introduced into `StatusTableViewController` where there appears to be an extra call to `redrawCharts`.   I'm hoping it fixes the crash.

* We don't quite want this yet not until LOOP-3938

Author: Rick Pasetto

Loop/Managers/Alerts/UserNotificationAlertIssuer.swift

@@ -68,7 +68,10 @@ fileprivate extension Alert {
         let userNotificationContent = UNMutableNotificationContent()
         userNotificationContent.title = content.title
         userNotificationContent.body = content.body
-        userNotificationContent.sound = getUserNotificationSound()
+        userNotificationContent.sound = userNotificationSound
+        if #available(iOS 15.0, *) {
+            userNotificationContent.interruptionLevel = backgroundContent?.isCritical == true ? .critical : .timeSensitive
+        }
         // TODO: Once we have a final design and approval for custom UserNotification buttons, we'll need to set categoryIdentifier
 //        userNotificationContent.categoryIdentifier = LoopNotificationCategory.alert.rawValue
         userNotificationContent.threadIdentifier = identifier.value // Used to match categoryIdentifier, but I /think/ we want multiple threads for multiple alert types, no?
@@ -78,8 +81,8 @@ fileprivate extension Alert {
         ]
         return userNotificationContent
     }
-
-    private func getUserNotificationSound() -> UNNotificationSound? {
+    
+    private var userNotificationSound: UNNotificationSound? {
         guard let content = backgroundContent else {
             return nil
         }

Loop/Managers/NotificationManager.swift

@@ -98,6 +98,9 @@ extension NotificationManager {
 
         notification.body = body
         notification.sound = .default
+        if #available(iOS 15.0, *) {
+            notification.interruptionLevel = .timeSensitive
+        }
 
         if startDate.timeIntervalSinceNow >= TimeInterval(minutes: -5) {
             notification.categoryIdentifier = LoopNotificationCategory.bolusFailure.rawValue
@@ -131,14 +134,20 @@ extension NotificationManager {
             formatter.allowedUnits = [.hour, .minute]
             formatter.unitsStyle = .full
 
-            if let failueIntervalString = formatter.string(from: failureInterval)?.localizedLowercase {
-                notification.body = String(format: NSLocalizedString("Loop has not completed successfully in %@", comment: "The notification alert describing a long-lasting loop failure. The substitution parameter is the time interval since the last loop"), failueIntervalString)
+            if let failureIntervalString = formatter.string(from: failureInterval)?.localizedLowercase {
+                notification.body = String(format: NSLocalizedString("Loop has not completed successfully in %@", comment: "The notification alert describing a long-lasting loop failure. The substitution parameter is the time interval since the last loop"), failureIntervalString)
             }
 
             notification.title = NSLocalizedString("Loop Failure", comment: "The notification title for a loop failure")
             if isCritical, FeatureFlags.criticalAlertsEnabled {
+                if #available(iOS 15.0, *) {
+                    notification.interruptionLevel = .critical
+                }
                 notification.sound = .defaultCritical
             } else {
+                if #available(iOS 15.0, *) {
+                    notification.interruptionLevel = .timeSensitive
+                }
                 notification.sound = .default
             }
             notification.categoryIdentifier = LoopNotificationCategory.loopNotRunning.rawValue

Loop/View Controllers/StatusTableViewController.swift

@@ -131,18 +131,6 @@ final class StatusTableViewController: LoopChartsTableViewController {
         tableView.backgroundColor = .secondarySystemBackground
 
         tableView.register(AlertPermissionsDisabledWarningCell.self, forCellReuseIdentifier: AlertPermissionsDisabledWarningCell.className)
-        notificationsCriticalAlertPermissionsViewModel.$showWarning
-            .receive(on: RunLoop.main)
-            .sink { [weak self] showWarning in
-                guard let self = self else { return }
-                let isWarningVisible = self.tableView.numberOfRows(inSection: Section.alertPermissionsDisabledWarning.rawValue) != 0
-                if !showWarning && isWarningVisible {
-                    self.tableView.deleteRows(at: [IndexPath(row: 0, section: Section.alertPermissionsDisabledWarning.rawValue)], with: .top)
-                } else if showWarning && !isWarningVisible {
-                    self.tableView.insertRows(at: [IndexPath(row: 0, section: Section.alertPermissionsDisabledWarning.rawValue)], with: .top)
-                }
-            }
-            .store(in: &cancellables)
     }
 
     override func didReceiveMemoryWarning() {
@@ -337,7 +325,6 @@ final class StatusTableViewController: LoopChartsTableViewController {
         }
 
         updateChartDateRange()
-        redrawCharts()
 
         if case .bolusing = statusRowMode, bolusProgressReporter?.progress.isComplete == true {
             refreshContext.update(with: .status)
@@ -350,6 +337,7 @@ final class StatusTableViewController: LoopChartsTableViewController {
         }
 
         guard active && visible && !refreshContext.isEmpty else {
+            redrawCharts()
             return
         }
 
@@ -582,7 +570,7 @@ final class StatusTableViewController: LoopChartsTableViewController {
             // Show/hide the table view rows
             let statusRowMode = self.determineStatusRowMode()
 
-            self.updateHUDandStatusRows(statusRowMode: statusRowMode, newSize: currentContext.newSize, animated: animated)
+            self.updateBannerAndHUDandStatusRows(statusRowMode: statusRowMode, newSize: currentContext.newSize, animated: animated)
 
             self.redrawCharts()
 
@@ -691,8 +679,18 @@ final class StatusTableViewController: LoopChartsTableViewController {
 
         return statusRowMode
     }
+    
+    private func updateBannerRow(animated: Bool) {
+        let warningWasVisible = tableView.numberOfRows(inSection: Section.alertPermissionsDisabledWarning.rawValue) != 0
+        let showWarning = notificationsCriticalAlertPermissionsViewModel.showWarning
+        if !showWarning && warningWasVisible {
+            tableView.deleteRows(at: [IndexPath(row: 0, section: Section.alertPermissionsDisabledWarning.rawValue)], with: animated ? .top : .none)
+        } else if showWarning && !warningWasVisible {
+            tableView.insertRows(at: [IndexPath(row: 0, section: Section.alertPermissionsDisabledWarning.rawValue)], with: animated ? .top : .none)
+        }
+    }
 
-    private func updateHUDandStatusRows(statusRowMode: StatusRowMode, newSize: CGSize?, animated: Bool) {
+    private func updateBannerAndHUDandStatusRows(statusRowMode: StatusRowMode, newSize: CGSize?, animated: Bool) {
         let hudWasVisible = self.shouldShowHUD
         let statusWasVisible = self.shouldShowStatus
 
@@ -701,7 +699,7 @@ final class StatusTableViewController: LoopChartsTableViewController {
         self.statusRowMode = statusRowMode
 
         if let newSize = newSize {
-            self.landscapeMode = newSize.width > newSize.height
+            landscapeMode = newSize.width > newSize.height
         }
 
         let hudIsVisible = self.shouldShowHUD
@@ -710,12 +708,14 @@ final class StatusTableViewController: LoopChartsTableViewController {
         hudView?.cgmStatusHUD?.isVisible = hudIsVisible
 
         tableView.beginUpdates()
+        
+        updateBannerRow(animated: animated)
 
         switch (hudWasVisible, hudIsVisible) {
         case (false, true):
-            self.tableView.insertRows(at: [IndexPath(row: 0, section: Section.hud.rawValue)], with: animated ? .top : .none)
+            tableView.insertRows(at: [IndexPath(row: 0, section: Section.hud.rawValue)], with: animated ? .top : .none)
         case (true, false):
-            self.tableView.deleteRows(at: [IndexPath(row: 0, section: Section.hud.rawValue)], with: animated ? .top : .none)
+            tableView.deleteRows(at: [IndexPath(row: 0, section: Section.hud.rawValue)], with: animated ? .top : .none)
         default:
             break
         }
@@ -1069,17 +1069,17 @@ final class StatusTableViewController: LoopChartsTableViewController {
 
                 switch statusRowMode {
                 case .pumpSuspended(let resuming) where !resuming:
-                    updateHUDandStatusRows(statusRowMode: .pumpSuspended(resuming: true) , newSize: nil, animated: true)
+                    updateBannerAndHUDandStatusRows(statusRowMode: .pumpSuspended(resuming: true) , newSize: nil, animated: true)
                     deviceManager.pumpManager?.resumeDelivery() { (error) in
                         DispatchQueue.main.async {
                             if let error = error {
                                 let alert = UIAlertController(with: error, title: NSLocalizedString("Failed to Resume Insulin Delivery", comment: "The alert title for a resume error"))
                                 self.present(alert, animated: true, completion: nil)
                                 if case .suspended = self.basalDeliveryState {
-                                    self.updateHUDandStatusRows(statusRowMode: .pumpSuspended(resuming: false), newSize: nil, animated: true)
+                                    self.updateBannerAndHUDandStatusRows(statusRowMode: .pumpSuspended(resuming: false), newSize: nil, animated: true)
                                 }
                             } else {
-                                self.updateHUDandStatusRows(statusRowMode: self.determineStatusRowMode(), newSize: nil, animated: true)
+                                self.updateBannerAndHUDandStatusRows(statusRowMode: self.determineStatusRowMode(), newSize: nil, animated: true)
                                 self.refreshContext.update(with: .insulin)
                                 self.log.debug("[reloadData] after manually resuming suspend")
                                 self.reloadData()
@@ -1097,7 +1097,7 @@ final class StatusTableViewController: LoopChartsTableViewController {
                         show(vc, sender: tableView.cellForRow(at: indexPath))
                     }
                 case .bolusing:
-                    updateHUDandStatusRows(statusRowMode: .cancelingBolus, newSize: nil, animated: true)
+                    updateBannerAndHUDandStatusRows(statusRowMode: .cancelingBolus, newSize: nil, animated: true)
                     deviceManager.pumpManager?.cancelBolus() { (result) in
                         DispatchQueue.main.async {
                             switch result {
@@ -1107,9 +1107,9 @@ final class StatusTableViewController: LoopChartsTableViewController {
                             case .failure(let error):
                                 self.presentErrorCancelingBolus(error)
                                 if case .inProgress(let dose) = self.bolusState {
-                                    self.updateHUDandStatusRows(statusRowMode: .bolusing(dose: dose), newSize: nil, animated: true)
+                                    self.updateBannerAndHUDandStatusRows(statusRowMode: .bolusing(dose: dose), newSize: nil, animated: true)
                                 } else {
-                                    self.updateHUDandStatusRows(statusRowMode: .hidden, newSize: nil, animated: true)
+                                    self.updateBannerAndHUDandStatusRows(statusRowMode: .hidden, newSize: nil, animated: true)
                                 }
                             }
                         }

Loop/View Models/SettingsViewModel.swift

@@ -62,11 +62,7 @@ public class SettingsViewModel: ObservableObject {
     let versionUpdateViewModel: VersionUpdateViewModel
 
     private weak var delegate: SettingsViewModelDelegate?
-    
-    var showWarning: Bool {
-        notificationsCriticalAlertPermissionsViewModel.showWarning
-    }
-    
+
     var didTapIssueReport: ((String) -> Void)? {
         delegate?.didTapIssueReport
     }

Loop/Views/SettingsView.swift

@@ -46,7 +46,7 @@ public struct SettingsView: View {
                 if FeatureFlags.automaticBolusEnabled {
                     dosingStrategySection
                 }
-                if viewModel.showWarning {
+                if viewModel.notificationsCriticalAlertPermissionsViewModel.showWarning {
                     alertPermissionsSection
                 }
                 if viewModel.pumpManagerSettingsViewModel.isSetUp() {
@@ -129,7 +129,7 @@ extension SettingsView {
             {
                 HStack {
                     Text(NSLocalizedString("Alert Permissions", comment: "Alert Permissions button text"))
-                    if viewModel.showWarning {
+                    if viewModel.notificationsCriticalAlertPermissionsViewModel.showWarning {
                         Spacer()
                         Image(systemName: "exclamationmark.triangle.fill")
                             .foregroundColor(.critical)