LOOP-3932: Fix memory leak when deleting CGM Manager (merge to dev) (#475)

Rick Pasetto · web-flow · commit 98fcc84c73f0 · 2021-11-10T10:15:31.000-08:00
https://tidepool.atlassian.net/browse/LOOP-3932
diff --git a/Loop/Managers/DeviceDataManager.swift b/Loop/Managers/DeviceDataManager.swift
@@ -805,7 +805,11 @@ extension DeviceDataManager: CGMManagerDelegate {
         log.default("CGM manager with identifier '%{public}@' wants deletion", manager.managerIdentifier)
 
         DispatchQueue.main.async {
+            if let cgmManagerUI = self.cgmManager as? CGMManagerUI {
+                self.removeDisplayGlucoseUnitObserver(cgmManagerUI)
+            }
             self.cgmManager = nil
+            self.displayGlucoseUnitObservers.cleanupDeallocatedElements()
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -805,7 +805,11 @@ extension DeviceDataManager: CGMManagerDelegate {`
`805`	`805`	`log.default("CGM manager with identifier '%{public}@' wants deletion", manager.managerIdentifier)`
`806`	`806`
`807`	`807`	`DispatchQueue.main.async {`
	`808`	`+ if let cgmManagerUI = self.cgmManager as? CGMManagerUI {`
	`809`	`+ self.removeDisplayGlucoseUnitObserver(cgmManagerUI)`
	`810`	`+ }`
`808`	`811`	`self.cgmManager = nil`
	`812`	`+ self.displayGlucoseUnitObservers.cleanupDeallocatedElements()`
`809`	`813`	`}`
`810`	`814`	`}`
`811`	`815`