Fix calibration decoding, and lagged backfill processing #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes LoopKit/Loop#2291 |
Contributor
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Code review looks reasonable (not an expert).
I will build and get this on Katie's phone - she does a lot of calibrations.
marionbarker
approved these changes
Apr 16, 2025
Contributor
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
This has run successfully for several days for two people (smoke test only).
I also ran the Tests and the new additions passed, as did all the other tests in LoopWorkspace dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calibration flag was not being decoded correctly, and all readings were marked as non-calibration. This fixes that.
If iOS drops the backfillFinished message, the backfill buffer might contain old messages, and get flushed at a much later time improperly. If the flushing happens after a new sensor is paired, the timestamp interpretation can be very off (by applying the large backfill offsets to the new sensor start date) See LoopKit/Loop#2291. This change flushes the backfill buffer on sensor disconnect, if there is anything in it.