Skip to content

Conversation

@cjumel
Copy link
Contributor

@cjumel cjumel commented Oct 31, 2025

Description

As the title says, the main element of this PR is to support pydantic.SecretStr as API key parameter. Additionally, the corresponding client attribute was also converted to a pydantic.SecretStr to decrease the risk of the API key leaking into logs for instance.

Besides this, this PR does two maintenance things:

  • enforce additional linting rules from our internal rule set (all those which could be fixed automatically, the ones requiring manual work are left for the future)
  • make internal modules and class variables private with single leading _

Checklist

  • I have installed pre-commit on this project (for instance with the make install-dev command)
    before creating any commit, or I have run successfully the make lint command on my changes
  • I have run successfully the make test command on my changes
  • I have updated the README.md if my changes affected it

@cjumel cjumel requested a review from BruceWouaigne October 31, 2025 10:19
@cjumel cjumel merged commit 1c34bf3 into main Oct 31, 2025
2 checks passed
@cjumel cjumel deleted the cj/secret branch October 31, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants