feat: accept API key as pydantic.SecretStr #57
Merged
+107
−85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title says, the main element of this PR is to support
pydantic.SecretStras API key parameter. Additionally, the corresponding client attribute was also converted to apydantic.SecretStrto decrease the risk of the API key leaking into logs for instance.Besides this, this PR does two maintenance things:
_Checklist
make install-devcommand)before creating any commit, or I have run successfully the
make lintcommand on my changesmake testcommand on my changesREADME.mdif my changes affected it