Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@akihironitta
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [n/a] Did you make sure to update the docs?
  • [n/a] Did you write any new necessary tests?

What does this PR do?

Fixes #135.

Used the following command to remove the tags:

find ./course_UvA-DL/ -type f -exec sed -i -- 's|<switch><g .*<\/switch>||g' {} +

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the documentation Improvements or additions to documentation label May 7, 2022
@akihironitta akihironitta changed the title Remove swtich tags from svg files Remove switch tags from svg files May 7, 2022
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #171 (ea8aa51) into main (01f7b62) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #171   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       370    370           
===================================
  Hits        276    276           
  Misses       94     94           

@akihironitta
Copy link
Contributor Author

Pasting one of the diffs in case reviewers can't see it in their browsers:

Screen Shot 2022-05-08 at 19 55 06

@akihironitta akihironitta enabled auto-merge (squash) May 11, 2022 11:42
@akihironitta akihironitta merged commit 3ab42a0 into main May 11, 2022
@akihironitta akihironitta deleted the bugfix/svg-render branch May 11, 2022 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation SVG rendering bug/warning in Chrome

2 participants