Skip to content

Fixed use of LightningCLI in computer_vision_fine_tuning.py example #9934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Fixed use of LightningCLI in computer_vision_fine_tuning.py example #9934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Reset `val_dataloader` in `tuner/batch_size_scaling` ([#9857](https://github.com/PyTorchLightning/pytorch-lightning/pull/9857))


- Fixed use of `LightningCLI` in computer_vision_fine_tuning.py example ([#9934](https://github.com/PyTorchLightning/pytorch-lightning/pull/9934))


## [1.4.9] - 2021-09-30

- Fixed `lr_find` to generate same results on multiple calls ([#9704](https://github.com/PyTorchLightning/pytorch-lightning/pull/9704))
Expand Down
10 changes: 4 additions & 6 deletions pl_examples/domain_templates/computer_vision_fine_tuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@

Note:
See: https://pytorch.org/tutorials/beginner/transfer_learning_tutorial.html

To run:
python computer_vision_fine_tuning.py fit
"""

import logging
Expand Down Expand Up @@ -265,7 +268,7 @@ def configure_optimizers(self):

class MyLightningCLI(LightningCLI):
def add_arguments_to_parser(self, parser):
parser.add_class_arguments(MilestonesFinetuning, "finetuning")
parser.add_lightning_class_args(MilestonesFinetuning, "finetuning")
parser.link_arguments("data.batch_size", "model.batch_size")
parser.link_arguments("finetuning.milestones", "model.milestones")
parser.link_arguments("finetuning.train_bn", "model.train_bn")
Expand All @@ -277,11 +280,6 @@ def add_arguments_to_parser(self, parser):
}
)

def instantiate_trainer(self, *args):
finetuning_callback = MilestonesFinetuning(**self._get(self.config_init, "finetuning"))
self.trainer_defaults["callbacks"] = [finetuning_callback]
return super().instantiate_trainer(*args)


def cli_main():
MyLightningCLI(TransferLearningModel, CatDogImageDataModule, seed_everything_default=1234)
Expand Down