-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback
#9921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #9921 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 179 179
Lines 15805 15808 +3
=======================================
- Hits 14648 14030 -618
- Misses 1157 1778 +621 |
DeviceStatsMonitor callback
DeviceStatsMonitor callbacklog_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback
Closed
12 tasks
kaushikb11
reviewed
Oct 14, 2021
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
tchaton
approved these changes
Oct 14, 2021
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
rohitgr7
reviewed
Oct 14, 2021
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
rohitgr7
approved these changes
Oct 14, 2021
kaushikb11
approved these changes
Oct 14, 2021
Contributor
kaushikb11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SkafteNicki
approved these changes
Oct 14, 2021
Co-authored-by: Rohit Gupta <[email protected]>
…onnector.py Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
carmocca
reviewed
Oct 14, 2021
carmocca
approved these changes
Oct 14, 2021
9 tasks
rohitgr7
added a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
… `DeviceStatsMonitor` callback (Lightning-AI#9921) Co-authored-by: Kaushik B <[email protected]> Co-authored-by: Rohit Gupta <[email protected]>
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback
deprecation
Includes a deprecation
design
Includes a design discussion
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecate
log_gpu_memoryfrom Trainer constructor, deprecategpu_metricsfrom LoggerConnector, and deprecate some util functions fromutilities/memory.py.These are all replaced by the
DeviceStatsCallbackwhich callsget_device_statson the Accelerator interface #9712Part of #9032
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃