Skip to content

Conversation

@daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Oct 14, 2021

What does this PR do?

Deprecate log_gpu_memory from Trainer constructor, deprecate gpu_metrics from LoggerConnector, and deprecate some util functions from utilities/memory.py.

These are all replaced by the DeviceStatsCallback which calls get_device_stats on the Accelerator interface #9712

Part of #9032

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #9921 (d6dabc2) into master (6feda08) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9921    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15805   15808     +3     
=======================================
- Hits        14648   14030   -618     
- Misses       1157    1778   +621     

@daniellepintz daniellepintz changed the title Deprecate log_gpu_memory, gpu_metrics, and util funcs Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback Oct 14, 2021
@daniellepintz daniellepintz changed the title Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback Oct 14, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 14, 2021
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohitgr7 rohitgr7 enabled auto-merge (squash) October 14, 2021 12:56
@mergify mergify bot removed the has conflicts label Oct 14, 2021
@carmocca carmocca merged commit 16213b1 into Lightning-AI:master Oct 14, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 14, 2021
@carmocca carmocca added design Includes a design discussion callback deprecation Includes a deprecation labels Oct 14, 2021
@daniellepintz daniellepintz deleted the dep_log_gpu branch October 14, 2021 20:48
rohitgr7 added a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
… `DeviceStatsMonitor` callback (Lightning-AI#9921)

Co-authored-by: Kaushik B <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback deprecation Includes a deprecation design Includes a design discussion ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants