-
Notifications
You must be signed in to change notification settings - Fork 3.6k
remove redundant accumulation normalization in manual optimization #9769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
reviewed
Sep 30, 2021
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Codecov Report
@@ Coverage Diff @@
## master #9769 +/- ##
======================================
Coverage 93% 93%
======================================
Files 178 178
Lines 15650 15716 +66
======================================
+ Hits 14492 14559 +67
+ Misses 1158 1157 -1 |
carmocca
approved these changes
Sep 30, 2021
ananthsub
approved these changes
Sep 30, 2021
s-rog
approved these changes
Oct 1, 2021
SkafteNicki
approved these changes
Oct 1, 2021
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
rohitgr7
pushed a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a small code improvement. Passing
normalize=trainer.accumulate_grad_batchesis redundant as its value is always 1. In fact, a user setting a value greater than 1 is leading to an error message from the Trainer anyway, as this is an unsupported feature for manual optimization.Before submitting
changelog update not required. The
ManualOptimizationloop changes are not not released.PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃