-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Refactor tests for TPU Accelerator #9718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
rohitgr7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you do git mv here?
Nope. |
Codecov Report
@@ Coverage Diff @@
## master #9718 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 179 179
Lines 15803 15805 +2
======================================
+ Hits 14647 14648 +1
- Misses 1156 1157 +1 |
|
Thanks for this cleanup @kaushikb11! Looks great, however I see the TPU tests are failing with |
It's very bizarre. Started to look into it! |
|
Any luck @kaushikb11? Did you try rerunning the test 😅? I'd like to merge this soon if possible so I can rebase #9712 on top |
1d3080f to
e624510
Compare
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
34b43ec to
9580b86
Compare
|
@kaushikb11 I see you still have the TPU test failure You believe this is due to |
9580b86 to
b06cba5
Compare
Co-authored-by: tchaton <[email protected]>
What does this PR do?
A couple of things happening here:
tests/accelerator/test_tpu_backend.pytotests/accelerator/test_tpu.pyDoes your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃