Skip to content

Conversation

@kaushikb11
Copy link
Contributor

What does this PR do?

A couple of things happening here:

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you do git mv here?

@kaushikb11
Copy link
Contributor Author

kaushikb11 commented Sep 27, 2021

did you do git mv here?

Nope.

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #9718 (938afdf) into master (a002f87) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9718   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         179     179           
  Lines       15803   15805    +2     
======================================
+ Hits        14647   14648    +1     
- Misses       1156    1157    +1     

@mergify mergify bot added the ready PRs ready to be merged label Sep 27, 2021
@daniellepintz
Copy link
Contributor

daniellepintz commented Sep 27, 2021

Thanks for this cleanup @kaushikb11! Looks great, however I see the TPU tests are failing with Exited with code exit status 1 (seems unrelated to any test failure?)

@awaelchli awaelchli added this to the v1.5 milestone Sep 27, 2021
@kaushikb11
Copy link
Contributor Author

however I see the TPU tests are failing with Exited with code exit status 1 (seems unrelated to any test failure?)

It's very bizarre. Started to look into it!

@daniellepintz
Copy link
Contributor

Any luck @kaushikb11? Did you try rerunning the test 😅? I'd like to merge this soon if possible so I can rebase #9712 on top

@mergify mergify bot added the has conflicts label Oct 6, 2021
@kaushikb11 kaushikb11 force-pushed the refactor/tpu_accelerator_tests branch from 1d3080f to e624510 Compare October 6, 2021 09:24
@Borda Borda requested a review from rohitgr7 October 12, 2021 10:03
@mergify mergify bot removed the has conflicts label Oct 12, 2021
@tchaton tchaton enabled auto-merge (squash) October 12, 2021 10:08
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kaushikb11 kaushikb11 force-pushed the refactor/tpu_accelerator_tests branch from 34b43ec to 9580b86 Compare October 13, 2021 14:08
@daniellepintz
Copy link
Contributor

@kaushikb11 I see you still have the TPU test failure Exited with code exit status 1 :/
https://app.circleci.com/pipelines/github/PyTorchLightning/pytorch-lightning/44976/workflows/4ed86e1b-7da9-4280-b3ee-a559023b276a/jobs/132914/parallel-runs/0/steps/0-119

You believe this is due to test_device_stats_tpu, correct? Would it make sense to delete the test if that is the case, since the logic is mostly tested in

https://github.com/PyTorchLightning/pytorch-lightning/blob/6feda08109cdf96173627b2599613e62b3d012dd/tests/callbacks/test_device_stats_monitor.py#L86

@kaushikb11 kaushikb11 force-pushed the refactor/tpu_accelerator_tests branch from 9580b86 to b06cba5 Compare October 14, 2021 19:02
@mergify mergify bot removed the has conflicts label Oct 14, 2021
@tchaton tchaton merged commit af4a8f1 into master Oct 14, 2021
@tchaton tchaton deleted the refactor/tpu_accelerator_tests branch October 14, 2021 19:45
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: tpu Tensor Processing Unit ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants