Skip to content

Make HorovodPlugin.all_gather return a tensor #9696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Make HorovodPlugin.all_gather return a tensor #9696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
628b2b3
Make `HorovodPlugin.all_gather` consistent with other plugins
ananthsub Sep 25, 2021
41f83ed
Update CHANGELOG.md
ananthsub Sep 25, 2021
0aa986e
Update horovod.py
ananthsub Sep 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Use a unique filename to save temp ckpt in tuner ([#96827](https://github.com/PyTorchLightning/pytorch-lightning/pull/9682))


- Changed `HorovodPlugin.all_gather` to return a `torch.Tensor` instead of a list ([#9696](https://github.com/PyTorchLightning/pytorch-lightning/pull/9696))


### Deprecated

- Deprecated `LightningModule.summarize()` in favor of `pytorch_lightning.utilities.model_summary.summarize()`
Expand Down
6 changes: 2 additions & 4 deletions pytorch_lightning/plugins/training_type/horovod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def reduce(self, tensor, group: Optional[Any] = None, reduce_op: Optional[Union[
return hvd.allreduce(tensor, op=reduce_op)

def all_gather(
self, result: Union[torch.Tensor], group: Optional[Any] = dist_group.WORLD, sync_grads: bool = False
self, result: torch.Tensor, group: Optional[Any] = dist_group.WORLD, sync_grads: bool = False
) -> torch.Tensor:
if group is not None and group != dist_group.WORLD:
raise ValueError("Horovod does not support allgather using a subcommunicator at this time. Unset `group`.")
Expand All @@ -183,9 +183,7 @@ def all_gather(

# sync and gather all
self.join()
gathered = hvd.allgather(result)
gathered_result = list(gathered.split(1, dim=0))
return gathered_result
return hvd.allgather(result)

def post_backward(self, closure_loss: torch.Tensor) -> None:
# synchronize all horovod optimizers.
Expand Down