Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 22, 2021

This reverts commit 904dde7, added in #9125.

Fixes #9631

The tests added in #9125 still pass. The new test added here fails on master and asserting the behavior how it was before #9125

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Sep 22, 2021
@awaelchli awaelchli added this to the v1.4.x milestone Sep 22, 2021
@awaelchli awaelchli changed the title revert #9125 / fix back compatibility with saving hparams as a whole container revert #9125 / fix back-compatibility with saving hparams as a whole container Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #9642 (d590033) into master (a71be50) will decrease coverage by 0%.
The diff coverage is 85%.

@@          Coverage Diff           @@
##           master   #9642   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         179     179           
  Lines       15317   15305   -12     
======================================
- Hits        14209   14197   -12     
  Misses       1108    1108           

@mergify mergify bot added the ready PRs ready to be merged label Sep 22, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) September 22, 2021 18:13
@tchaton tchaton merged commit b98ce0a into master Sep 22, 2021
@tchaton tchaton deleted the bugfix/revert-9125 branch September 22, 2021 18:13
awaelchli added a commit that referenced this pull request Sep 22, 2021
lexierule pushed a commit that referenced this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect "hparam_name" saved to checkpoint when saving from a params in a container

4 participants