Skip to content

Conversation

@hankyul2
Copy link
Contributor

@hankyul2 hankyul2 commented Sep 18, 2021

  • Fix typo in LightningModule.configure_callbacks()

What does this PR do?

Fix typo in LightningModule.configure_callbacks() document (document link)

Change is monitor"val_acc" -> monitor="val_acc" (insert = statement)
image

This seems to so small typo, so I did not make any issue.

Does your PR introduce any breaking changes? If yes, please list them.

Nope

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Of course, I do 😁

- Fix typo in LightningModule.configure_callbacks()
@ananthsub ananthsub added the docs Documentation related label Sep 18, 2021
@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #9591 (cfdee80) into master (f5608e9) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9591    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         181     181            
  Lines       15349   15349            
=======================================
- Hits        14246   13630   -616     
- Misses       1103    1719   +616     

@awaelchli awaelchli added this to the v1.5 milestone Sep 18, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 18, 2021
@mergify mergify bot requested a review from a team September 18, 2021 09:23
@carmocca carmocca merged commit c66d30a into Lightning-AI:master Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants