Skip to content

Conversation

@carmocca
Copy link
Contributor

What does this PR do?

Fixes #9528

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Sep 17, 2021
@carmocca carmocca added this to the v1.4.x milestone Sep 17, 2021
@carmocca carmocca self-assigned this Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #9582 (360bdcb) into master (bbcb977) will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9582    +/-   ##
=======================================
+ Coverage      89%     92%    +3%     
=======================================
  Files         181     181            
  Lines       15245   15728   +483     
=======================================
+ Hits        13549   14445   +896     
+ Misses       1696    1283   -413     

@carmocca carmocca enabled auto-merge (squash) September 17, 2021 22:11
@carmocca carmocca changed the title Fix ResultCollection._get_cache with multidimensional tensors Fix ResultCollection._get_cache with multielement tensors Sep 18, 2021
@carmocca carmocca disabled auto-merge September 18, 2021 13:44
@carmocca carmocca enabled auto-merge (squash) September 18, 2021 13:44
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@tchaton tchaton added the ready PRs ready to be merged label Sep 18, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@carmocca carmocca merged commit 8f1c855 into master Sep 22, 2021
@carmocca carmocca deleted the bugfix/cache-is-none branch September 22, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with metrics with None averaging

4 participants