-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix optimizer loop with frequencies #9507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
55f2c65 to
2b133b9
Compare
35f6a78 to
64f5ade
Compare
Codecov Report
@@ Coverage Diff @@
## master #9507 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 180 180
Lines 15107 15096 -11
======================================
- Hits 14033 14011 -22
- Misses 1074 1085 +11 |
carmocca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great other than my previous comment 👍
for more information, see https://pre-commit.ci
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
What does this PR do?
When extracting the optimizer loop #9191 , we broke the support for multiple optimizers that have different frequencies (deeply sorry for the inconvenience this has caused). This PR fixes that and adds a test.
No attached issue, found this while working on #9490 with @carmocca
Verified that the added test passes fine on 1.4.x branch.
Here is the failure we see on master:
Before submitting
NOT NEEDED
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃