Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 14, 2021

What does this PR do?

When extracting the optimizer loop #9191 , we broke the support for multiple optimizers that have different frequencies (deeply sorry for the inconvenience this has caused). This PR fixes that and adds a test.
No attached issue, found this while working on #9490 with @carmocca

Verified that the added test passes fine on 1.4.x branch.
Here is the failure we see on master:

        optimizer_sequence = [opt._optimizer.__class__.__name__ for opt in pl_optimizer_sequence]
>       assert optimizer_sequence == ["SGD", "SGD", "SGD", "Adam", "SGD", "SGD", "SGD", "Adam", "SGD", "SGD"]
E       AssertionError: assert ['SGD', 'SGD', 'SGD', 'SGD', 'SGD', 'SGD', 'SGD', 'SGD', 'SGD', 'SGD'] == ['SGD', 'SGD', 'SGD', 'Adam', 'SGD', 'SGD', 'SGD', 'Adam', 'SGD', 'SGD']

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
    NOT NEEDED

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Sep 14, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 14, 2021
@awaelchli awaelchli force-pushed the bugfix/optimizer_freq branch from 55f2c65 to 2b133b9 Compare September 14, 2021 10:48
@awaelchli awaelchli force-pushed the bugfix/optimizer_freq branch from 35f6a78 to 64f5ade Compare September 14, 2021 10:55
@awaelchli awaelchli marked this pull request as ready for review September 14, 2021 12:26
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #9507 (8367cc3) into master (1814334) will decrease coverage by 0%.
The diff coverage is 100%.

❗ Current head 8367cc3 differs from pull request most recent head d821ad3. Consider uploading reports for the commit d821ad3 to get more accurate results

@@          Coverage Diff           @@
##           master   #9507   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         180     180           
  Lines       15107   15096   -11     
======================================
- Hits        14033   14011   -22     
- Misses       1074    1085   +11     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than my previous comment 👍

@mergify mergify bot removed the has conflicts label Sep 14, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Sep 14, 2021
@SeanNaren SeanNaren merged commit 0421f08 into master Sep 14, 2021
@SeanNaren SeanNaren deleted the bugfix/optimizer_freq branch September 14, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants