Skip to content

Conversation

@stancld
Copy link
Contributor

@stancld stancld commented Sep 11, 2021

Still, WIP and some mypy issues need to be fixed.

What does this PR do?

Part of #7037. This PR disentangles large #7218. It fixes mypy typing in utilities.auto_restart.py

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@stancld stancld changed the title Fix mypy typing for utilities.auto_restart [WIP] Fix mypy typing for utilities.auto_restart Sep 11, 2021
@stale
Copy link

stale bot commented Sep 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Sep 26, 2021
if not isinstance(dataloader.dataset, CaptureIterableDataset):
fast_forward_sampler = _find_fast_forward_samplers(dataloader)
if fast_forward_sampler is not None:
out.update(fast_forward_sampler.state_dict(num_batches_processed=num_batches_processed))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't update works ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns me the following mypy error on my local:

pytorch_lightning/utilities/auto_restart.py:421: error: Argument 1 to "update" of "dict" has incompatible type "Dict[int, Dict[str, int]]"; expected "Mapping[Union[int, str], Union[Dict[str, int], int, None]]"  [arg-type]

@stale stale bot removed the won't fix This will not be worked on label Sep 27, 2021
@stale
Copy link

stale bot commented Oct 15, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Oct 15, 2021
@stale
Copy link

stale bot commented Oct 21, 2021

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

won't fix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants