Skip to content

Remove should_rank_save_checkpoint property from Trainer #9433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 13, 2021
Merged

Remove should_rank_save_checkpoint property from Trainer #9433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
564f9c6
Remove should_rank_save_checkpoint property from Trainer
kaushikb11 Sep 10, 2021
6a53896
Update Changelog
kaushikb11 Sep 10, 2021
0f34ad8
Update reference
kaushikb11 Sep 10, 2021
4e93c34
Remove unnecessary makedirs
kaushikb11 Sep 20, 2021
94e088c
Merge branch 'master' into remove/should_rank_save_checkpoint__property
kaushikb11 Oct 12, 2021
545e909
Update
kaushikb11 Oct 13, 2021
a7525fa
Merge branch 'master' into remove/should_rank_save_checkpoint__property
kaushikb11 Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Remove `epoch` from `trainer.logged_metrics` ([#9904](https://github.com/PyTorchLightning/pytorch-lightning/pull/9904))


- Removed `should_rank_save_checkpoint` property from Trainer ([#9433](https://github.com/PyTorchLightning/pytorch-lightning/pull/9433))


### Fixed


Expand Down
2 changes: 1 addition & 1 deletion pytorch_lightning/callbacks/model_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ def __resolve_ckpt_dir(self, trainer: "pl.Trainer") -> None:

self.dirpath = ckpt_path

if not trainer.fast_dev_run and trainer.should_rank_save_checkpoint:
if not trainer.fast_dev_run and trainer.training_type_plugin.should_rank_save_checkpoint:
self._fs.makedirs(self.dirpath, exist_ok=True)

def __warn_if_dir_not_empty(self, dirpath: _PATH) -> None:
Expand Down
4 changes: 0 additions & 4 deletions pytorch_lightning/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,10 +1507,6 @@ def world_size(self) -> int:
# some training types define a world size
return getattr(self.accelerator.training_type_plugin, "world_size", 1)

@property
def should_rank_save_checkpoint(self) -> bool:
return self.accelerator.training_type_plugin.should_rank_save_checkpoint

@property
def _distrib_type(self) -> DistributedType:
return self.accelerator_connector._distrib_type
Expand Down