Skip to content

Conversation

@s-rog
Copy link
Contributor

@s-rog s-rog commented Sep 10, 2021

What does this PR do?

Fixes #9102 (which adds missing docs for #3792)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Notes

Perhaps the bottom is not the best place for this?
preview

@s-rog s-rog self-assigned this Sep 10, 2021
@s-rog s-rog added the docs Documentation related label Sep 10, 2021
@s-rog s-rog added this to the v1.4.x milestone Sep 10, 2021
@s-rog s-rog marked this pull request as ready for review September 10, 2021 06:40
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #9428 (a1db3ee) into master (c963bf6) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9428    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         179     180     +1     
  Lines       14927   15064   +137     
=======================================
+ Hits        13868   13984   +116     
- Misses       1059    1080    +21     

@akihironitta
Copy link
Contributor

@awaelchli awaelchli modified the milestones: v1.4.x, v1.5 Sep 12, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 12, 2021
@s-rog s-rog force-pushed the docs/datamodule-hparams branch from 7fb7a8d to 7a9337d Compare September 13, 2021 01:32
@kaushikb11 kaushikb11 merged commit 81ac340 into master Sep 13, 2021
@kaushikb11 kaushikb11 deleted the docs/datamodule-hparams branch September 13, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add docs for datamodule hparams

4 participants