Skip to content

Deprecate LightningLoggerBase.close #9422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Sep 20, 2021
Merged

Deprecate LightningLoggerBase.close #9422

merged 27 commits into from
Sep 20, 2021

Conversation

@jjenniferdai
Copy link
Contributor

@jjenniferdai jjenniferdai commented Sep 9, 2021 •
edited by carmocca
Loading

What does this PR do?

Fixes #9421
deprecate LightningLoggerBase.close

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added deprecation Includes a deprecation logger Related to the Loggers labels Sep 9, 2021
ananthsub
ananthsub reviewed Sep 9, 2021
View reviewed changes
@jjenniferdai jjenniferdai changed the title deprecate LightningLoggerBase.close [wip] deprecate LightningLoggerBase.close Sep 9, 2021
@edward-io
Copy link
Contributor

edward-io commented Sep 9, 2021

Looks great, you can convert this into a non-draft PR when you're ready.

ananthsub
ananthsub reviewed Sep 10, 2021
View reviewed changes
@jjenniferdai
Copy link
Contributor Author

jjenniferdai commented Sep 10, 2021

trying to figure out the make-docs failure. (found similar error in #9366 but the suggestion doesn't seem to apply here)

ananthsub
ananthsub reviewed Sep 10, 2021
View reviewed changes
awaelchli
awaelchli reviewed Sep 10, 2021
View reviewed changes
ananthsub
ananthsub reviewed Sep 10, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #9422 (7ca038b) into master (089ae9b) will decrease coverage by 3%.
The diff coverage is 95%.

❗ Current head 7ca038b differs from pull request most recent head df63517. Consider uploading reports for the commit df63517 to get more accurate results

@@           Coverage Diff           @@
##           master   #9422    +/-   ##
=======================================
- Coverage      92%     89%    -3%     
=======================================
  Files         179     180     +1     
  Lines       14905   15046   +141     
=======================================
- Hits        13751   13358   -393     
- Misses       1154    1688   +534

awaelchli
awaelchli reviewed Sep 11, 2021
View reviewed changes
awaelchli
awaelchli reviewed Sep 12, 2021
View reviewed changes
@awaelchli awaelchli added this to the v1.5 milestone Sep 12, 2021
Borda
Borda reviewed Sep 14, 2021
View reviewed changes
tchaton
tchaton approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ananthsub ananthsub marked this pull request as ready for review September 14, 2021 17:52
@carmocca carmocca changed the title [wip] deprecate LightningLoggerBase.close Deprecate LightningLoggerBase.close Sep 15, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2021
@jjenniferdai jjenniferdai mentioned this pull request Sep 20, 2021
Closed
@ananthsub ananthsub enabled auto-merge (squash) September 20, 2021 21:43
@ananthsub ananthsub merged commit cc77367 into Lightning-AI:master Sep 20, 2021
@jjenniferdai jjenniferdai deleted the deprecate-loggerbase-close branch September 21, 2021 17:51
SeanNaren pushed a commit that referenced this pull request Sep 22, 2021
@jjenniferdai @pre-commit-ci
@ananthsub @awaelchli @tchaton @Borda
Deprecate LightningLoggerBase.close (#9422)
307d77a 
* deprecate loggerbase.close

* deprecate warning

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add to changelog

* fix import

* fix import alphabetize

* spacing?

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* copy-paste avoid pre-commit.ci?

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* literally match the other comment

* unindent

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* suggest finalize instead of save

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update tests/loggers/test_base.py

* format but to be formatted

* Update pytorch_lightning/loggers/base.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update pytorch_lightning/loggers/base.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update pytorch_lightning/loggers/base.py

Co-authored-by: Jirka Borovec <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
@akihironitta akihironitta mentioned this pull request Oct 27, 2022
Closed
7 tasks
@Borda Borda mentioned this pull request Mar 10, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda left review comments

@tchaton tchaton tchaton approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+4 more reviewers

@awaelchli awaelchli awaelchli left review comments

@carmocca carmocca carmocca approved these changes

@edward-io edward-io edward-io left review comments

@ananthsub ananthsub ananthsub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deprecation Includes a deprecation logger Related to the Loggers ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.5

Development

Successfully merging this pull request may close these issues.

Deprecate LightningLoggerBase.close

7 participants

@jjenniferdai @edward-io @ananthsub @awaelchli @Borda @carmocca @tchaton