Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Sep 5, 2021

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 marked this pull request as ready for review September 5, 2021 20:21
@Borda Borda enabled auto-merge (squash) September 5, 2021 20:36
@Borda Borda added docs Documentation related ci Continuous Integration labels Sep 5, 2021
@mergify mergify bot added the ready PRs ready to be merged label Sep 5, 2021
@mergify mergify bot requested a review from a team September 5, 2021 20:39
@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #9339 (13944e1) into master (cf1a589) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9339   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         178     178           
  Lines       14858   14858           
======================================
  Hits        13709   13709           
  Misses       1149    1149           

@Borda Borda merged commit ff1e691 into master Sep 5, 2021
@Borda Borda deleted the readme/ci_badge branch September 5, 2021 23:38
@carmocca carmocca added this to the v1.5 milestone Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants