Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

Follow up to #9188, #9326

Replaces the calls to the internal dev debugger in the early stopping callback. Tests are updated to cover what the "debugger" offered for tracking the calls inside the callback.
This is just one step towards removing the InternalDebugger completely in favor of proper unit testing.

Does your PR introduce any breaking changes? If yes, please list them.

No, the "InternalDebugger" is internal as the name suggests.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added ci Continuous Integration callback labels Sep 5, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 5, 2021
@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #9327 (b130961) into master (cf1a589) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9327   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         178     178           
  Lines       14858   14852    -6     
======================================
- Hits        13709   13703    -6     
  Misses       1149    1149           

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 6, 2021
@Borda Borda merged commit f9132e8 into master Sep 6, 2021
@Borda Borda deleted the feature/dev_debugger/remove-es branch September 6, 2021 08:43
@carmocca carmocca mentioned this pull request Sep 23, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants