-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix progress bar restart with fault-tolerant training enabled #9310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
commented
Sep 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #9310 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 178 178
Lines 14850 15402 +552
=======================================
+ Hits 13701 14241 +540
- Misses 1149 1161 +12 |
carmocca
approved these changes
Sep 5, 2021
tchaton
approved these changes
Sep 6, 2021
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat !
Borda
approved these changes
Sep 6, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a TODO in #9130
The progress bar callback did not resume correctly, because of two reasons:
on_train_start()was resuming the correct progress value buton_train_epoch_start()would overwrite it back to 0on_*_epoch_starthooks reset the tqdm counter to 0 instead of the value we would resume fromThis came up in the context of fault tolerant training.
Repro script
The added test fails on master.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃