Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 2, 2021

What does this PR do?

Part of #7938
Follow up to #9191

Resolves a TODO after splitting automatic optimization into a separate loop class.
The backward method on the TrainingBatchLoop is no necessary anymore as it is only rerouting a call to the accelerator.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added this to the v1.5 milestone Sep 2, 2021
@awaelchli awaelchli mentioned this pull request Sep 2, 2021
11 tasks
Base automatically changed from refactor/optimizer-loop to master September 2, 2021 11:40
@awaelchli awaelchli marked this pull request as ready for review September 2, 2021 13:53
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 2, 2021
@awaelchli awaelchli enabled auto-merge (squash) September 2, 2021 16:26
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #9265 (45061bc) into master (7535093) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9265    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         178     178            
  Lines       14889   14885     -4     
=======================================
- Hits        13736   13118   -618     
- Misses       1153    1767   +614     

@awaelchli awaelchli merged commit b91747e into master Sep 3, 2021
@awaelchli awaelchli deleted the refactor/manual-backward branch September 3, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants