Skip to content

Conversation

@daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Sep 1, 2021

What does this PR do?

This callback hook will be subsumed by the new on_exception hook (#9183).
The PR includes small addition to the is_overridden helper function, to automatically set the parent to Callback if a Callback instance is passed, which made changes to configuration_validator.py simpler.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the v1.5 milestone Sep 1, 2021
@carmocca carmocca added deprecation Includes a deprecation callback labels Sep 1, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMTG

@mergify mergify bot added the ready PRs ready to be merged label Sep 1, 2021
@daniellepintz
Copy link
Contributor Author

Waiting to merge - will incorporate fix for #9286

@Borda
Copy link
Collaborator

Borda commented Sep 2, 2021

Waiting to merge

there are still some failing tests, mind have look?

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #9260 (a6299a8) into master (ccc83e7) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head a6299a8 differs from pull request most recent head 21b8abe. Consider uploading reports for the commit 21b8abe to get more accurate results

@@           Coverage Diff           @@
##           master   #9260    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         176     178     +2     
  Lines       14810   14854    +44     
=======================================
- Hits        13662   13093   -569     
- Misses       1148    1761   +613     

Co-authored-by: Carlos Mocholí <[email protected]>
@Borda Borda requested a review from ananthsub September 6, 2021 07:55
@Borda Borda merged commit 912fd31 into Lightning-AI:master Sep 6, 2021
@daniellepintz daniellepintz deleted the dep_keyboard branch September 6, 2021 22:28
@Borda Borda changed the title Deprecate on_keyboard_interrupt callback hook Deprecate on_keyboard_interrupt callback hook Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback deprecation Includes a deprecation ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants