Skip to content

Conversation

@kaushikb11
Copy link
Contributor

What does this PR do?

Remove shown_warnings dead code from Trainer

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 marked this pull request as ready for review August 31, 2021 14:26
@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kaushikb11 kaushikb11 enabled auto-merge (squash) August 31, 2021 14:43
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #9230 (b2e31c7) into master (f6614b3) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9230    +/-   ##
=======================================
  Coverage      92%     92%            
=======================================
  Files         176     176            
  Lines       14805   15070   +265     
=======================================
+ Hits        13658   13923   +265     
  Misses       1147    1147            

@kaushikb11 kaushikb11 merged commit 3e71046 into master Aug 31, 2021
@kaushikb11 kaushikb11 deleted the remove/shown_warnings branch August 31, 2021 17:00
@ethanwharris ethanwharris added this to the v1.4.x milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants