Skip to content

Conversation

@ethanwharris
Copy link
Member

What does this PR do?

Adds our turoial extension to enable compatibility with future updates to lightning tutorials.

Note: This doesn't change the docs in any way at this stage, just prevents an error that may occur when lightning tutorials is updated.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Aug 27, 2021
@mergify mergify bot requested a review from a team August 27, 2021 13:23
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanwharris should this be merged to a bug-fix release?

@ethanwharris
Copy link
Member Author

@carmocca that would probably be safest as it's a totally backward compatible change 😃

@carmocca carmocca added this to the v1.4.x milestone Aug 27, 2021
@carmocca carmocca merged commit b5fb49a into master Aug 27, 2021
@carmocca carmocca deleted the docs/add_extension branch August 27, 2021 15:14
@awaelchli awaelchli added the docs Documentation related label Aug 28, 2021
ethanwharris added a commit that referenced this pull request Aug 31, 2021
lexierule pushed a commit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants