Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Aug 27, 2021

What does this PR do?

Closes #9144
Closes #9152

Updates documentation to explain usage of activation checkpointing a bit better!

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the docs Documentation related label Aug 27, 2021
@SeanNaren SeanNaren added this to the v1.5 milestone Aug 27, 2021
@SeanNaren SeanNaren self-assigned this Aug 27, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #9165 (0873ce0) into master (e133061) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9165    +/-   ##
=======================================
  Coverage      92%     92%            
=======================================
  Files         176     176            
  Lines       14804   15083   +279     
=======================================
+ Hits        13651   13929   +278     
- Misses       1153    1154     +1     

@SeanNaren SeanNaren enabled auto-merge (squash) August 27, 2021 10:49
@mergify mergify bot added the ready PRs ready to be merged label Aug 27, 2021
@mergify mergify bot requested a review from a team August 27, 2021 12:45
@SeanNaren SeanNaren merged commit 3fd77cb into master Aug 28, 2021
@SeanNaren SeanNaren deleted the docs/deepspeed_checkpointing branch August 28, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve docs to explain DeepSpeedPlugin with activation checkpointing

5 participants