Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 26, 2021

What does this PR do?

Fixes #9107

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #9141 (8e0cc81) into master (53885af) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9141   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         176     176           
  Lines       14790   14810   +20     
======================================
+ Hits        13638   13657   +19     
- Misses       1152    1153    +1     

@tchaton tchaton enabled auto-merge (squash) August 26, 2021 17:29
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small suggestion

@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2021
@ananthsub ananthsub added the docs Documentation related label Aug 26, 2021
@tchaton tchaton merged commit fcbfc6b into master Aug 27, 2021
@tchaton tchaton deleted the doc_randomness branch August 27, 2021 07:59
ethanwharris pushed a commit that referenced this pull request Aug 31, 2021
@ethanwharris ethanwharris added this to the v1.4.x milestone Aug 31, 2021
lexierule pushed a commit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link to https://pytorch.org/docs/stable/notes/randomness.html

6 participants