-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add doc strings to CSV logger #9112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
awaelchli
merged 3 commits into
Lightning-AI:master
from
bamblebam:csv-_logs-doc-strings
Sep 1, 2021
Merged
Add doc strings to CSV logger #9112
awaelchli
merged 3 commits into
Lightning-AI:master
from
bamblebam:csv-_logs-doc-strings
Sep 1, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
approved these changes
Aug 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #9112 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 178 175 -3
Lines 14694 14665 -29
=======================================
- Hits 13526 12888 -638
- Misses 1168 1777 +609 |
tchaton
approved these changes
Aug 26, 2021
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ethanwharris
approved these changes
Aug 26, 2021
SkafteNicki
approved these changes
Aug 26, 2021
Borda
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9028
Adds docstrings to the CSV logger class.
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃