Skip to content

Conversation

@kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Aug 24, 2021

What does this PR do?

pre-commit ci is a required job for merge.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli
Copy link
Contributor

@kaushikb11 we just enabled pre-commit as a required job today

@awaelchli awaelchli added the priority: 0 High priority task label Aug 24, 2021
@carmocca carmocca added this to the v1.5 milestone Aug 24, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 24, 2021
@mergify mergify bot requested a review from a team August 24, 2021 15:33
@carmocca carmocca changed the title Important [Blocking merging PRs]: Fix mypy for unused imports [Blocking CI] Fix pep8 error about unused imports Aug 24, 2021
@kaushikb11 kaushikb11 merged commit 1a2468f into master Aug 24, 2021
@kaushikb11 kaushikb11 deleted the fix/mypy branch August 24, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: 0 High priority task ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants