Skip to content

Conversation

@EricWiener
Copy link
Contributor

@EricWiener EricWiener commented Aug 24, 2021

What does this PR do?

Moves predictions to CPU before accumulating.

See discussion: #7485

Does your PR introduce any breaking changes? If yes, please list them.

Predictions are stored on cpu instead of device.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Note: I believe we shouldn't do this before the on_predict_batch_end as some users might do some post processing on device.

@tchaton tchaton added the ready PRs ready to be merged label Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #9085 (3f7d0ed) into master (6f3cb1a) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head 3f7d0ed differs from pull request most recent head e1e242a. Consider uploading reports for the commit e1e242a to get more accurate results

@@           Coverage Diff           @@
##           master   #9085    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         178     178            
  Lines       14692   14693     +1     
=======================================
- Hits        13524   12918   -606     
- Misses       1168    1775   +607     

@awaelchli awaelchli added this to the v1.5 milestone Aug 25, 2021
@mergify mergify bot requested a review from a team August 25, 2021 23:56
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Missing the torch import

@tchaton tchaton merged commit dfffb94 into Lightning-AI:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants