Skip to content

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Aug 24, 2021

Found this when going through the trainer constructor and various connectors.

The typhint was inconsistent with the trainer behavior. List[list] is not supported and raised a TypeError if passed in. This PR removes the misleading typehint from the trainer constructor

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Found when going through the trainer constructor and various connectors.

The typhint was inconsistent with the trainer behavior. List[int] was never supported and raised a TypeError if passed in. This PR removes the misleading typehint from the trainer constructor
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #9071 (3b0fab2) into master (538e743) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head 3b0fab2 differs from pull request most recent head 1937493. Consider uploading reports for the commit 1937493 to get more accurate results

@@           Coverage Diff           @@
##           master   #9071    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         178     178            
  Lines       14659   14694    +35     
=======================================
- Hits        13495   12917   -578     
- Misses       1164    1777   +613     

@mergify mergify bot added the ready PRs ready to be merged label Aug 24, 2021
@ananthsub ananthsub modified the milestones: v1.5, v1.4.x Aug 24, 2021
@ananthsub ananthsub enabled auto-merge (squash) August 24, 2021 16:15
@ananthsub ananthsub merged commit 376734a into Lightning-AI:master Aug 24, 2021
@ananthsub ananthsub deleted the fix/accumulated-grad-batches-type branch August 24, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants