Skip to content

Conversation

@kaushikb11
Copy link
Contributor

What does this PR do?

It is duplicated in DDP & DDPSpawn plugins.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added distributed Generic distributed-related topic refactor labels Aug 23, 2021
@kaushikb11 kaushikb11 added this to the v1.5 milestone Aug 23, 2021
@kaushikb11 kaushikb11 self-assigned this Aug 23, 2021
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @four4fish as collective initialization could be part of #7534

if the plugin initializes the global procss group, then we have higher confidence that the global process group can be destroyed in the teardown

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #9044 (cef5d3d) into master (8a93173) will increase coverage by 0%.
The diff coverage is 50%.

@@          Coverage Diff           @@
##           master   #9044   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         175     175           
  Lines       14379   14361   -18     
======================================
- Hits        13322   13312   -10     
+ Misses       1057    1049    -8     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready PRs ready to be merged label Aug 23, 2021
@kaushikb11 kaushikb11 merged commit 0461107 into master Aug 23, 2021
@kaushikb11 kaushikb11 deleted the utility/init_ddp_connection branch August 23, 2021 08:31
@carmocca
Copy link
Contributor

Hi @kaushikb11. Mind addressing the failing mypy job in a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distributed Generic distributed-related topic ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants