Fix datamodule.size return value typing

[Knarik1]

What does this PR do?

Fix mismatch between return value type and its description.

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• [n/a] Did you write any new necessary tests? (not for typos and docs)
• [n/a] Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun? Yes

Make sure you had fun coding 🙃

[Knarik1]

Yes, type is arbitrary.

…

On Tue, Aug 17, 2021 at 12:35 PM Adrian Wälchli ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pytorch_lightning/core/datamodule.py <#8949 (comment)> : > @@ -184,7 +184,7 @@ def dims(self, d): rank_zero_deprecation("DataModule property `dims` was deprecated in v1.5 and will be removed in v1.7.") self._dims = d - def size(self, dim=None) -> Union[Tuple, int]: + def size(self, dim=None) -> Union[Tuple, List[Tuple]]: according to the doc above, dims is a tuple, but type is not annotated so it can be anything really. therefore type here is also arbitrary, right? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8949 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AESNGY2Y3QVS2PCTET6U65LT5INMTANCNFSM5CJGUHXQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[codecov]

Codecov Report

Merging #8949 (9a2cd18) into master (0461107) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8949    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         175     175            
  Lines       14361   14373    +12     
=======================================
- Hits        13312   12739   -573     
- Misses       1049    1634   +585