Skip to content

Conversation

@stancld
Copy link
Contributor

@stancld stancld commented Aug 6, 2021

What does this PR do?

Part of #7037. This PR disentangles large #7218. It fixes mypy typing in utilities.apply_func.py

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #8781 (a834848) into master (0752bcd) will decrease coverage by 4%.
The diff coverage is 94%.

@@           Coverage Diff           @@
##           master   #8781    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         176     176            
  Lines       14744   14788    +44     
=======================================
- Hits        13556   13024   -532     
- Misses       1188    1764   +576     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@stancld stancld changed the title [WIP] Fix mypy typing for utilities.apply_func Fix mypy typing for utilities.apply_func Aug 22, 2021
@stancld stancld marked this pull request as ready for review August 22, 2021 12:27
@awaelchli awaelchli added this to the v1.5 milestone Aug 22, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 22, 2021
@Borda Borda enabled auto-merge (squash) August 24, 2021 07:02
@carmocca carmocca disabled auto-merge August 26, 2021 16:09
@carmocca carmocca enabled auto-merge (squash) August 26, 2021 16:09
@carmocca carmocca merged commit 53885af into Lightning-AI:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants