Skip to content

convert warning cache usage to rank_zero_only in WandbLogger #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 20, 2021
Merged

convert warning cache usage to rank_zero_only in WandbLogger #8764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9ed5b5e
add warning
awaelchli Aug 4, 2021
3646938
update test
awaelchli Aug 4, 2021
82da099
update changelog
awaelchli Aug 4, 2021
18eaf59
Merge branch 'master' into feature/wandb-multi-run
awaelchli Aug 4, 2021
d11e27e
convert warning cache
awaelchli Aug 6, 2021
ba55fa4
update other cache usages
awaelchli Aug 6, 2021
0c3545b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 6, 2021
26809bf
Merge branch 'master' into feature/wandb-warn-cache
awaelchli Aug 12, 2021
d6a73a6
update test
awaelchli Aug 13, 2021
9aed18b
Merge branch 'master' into feature/wandb-warn-cache
awaelchli Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pytorch_lightning/loggers/wandb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
from pytorch_lightning.utilities import _module_available, rank_zero_only
from pytorch_lightning.utilities.exceptions import MisconfigurationException
from pytorch_lightning.utilities.imports import _compare_version
from pytorch_lightning.utilities.warnings import WarningCache

warning_cache = WarningCache()
from pytorch_lightning.utilities.warnings import rank_zero_deprecation, rank_zero_warn

_WANDB_AVAILABLE = _module_available("wandb")
_WANDB_GREATER_EQUAL_0_10_22 = _compare_version("wandb", operator.ge, "0.10.22")
Expand Down Expand Up @@ -129,7 +127,7 @@ def __init__(
)

if log_model and not _WANDB_GREATER_EQUAL_0_10_22:
warning_cache.warn(
rank_zero_warn(
f"Providing log_model={log_model} requires wandb version >= 0.10.22"
" for logging associated model metadata.\n"
"Hint: Upgrade with `pip install --ugrade wandb`."
Expand Down Expand Up @@ -186,7 +184,7 @@ def experiment(self) -> Run:
if wandb.run is None:
self._experiment = wandb.init(**self._wandb_init)
else:
warning_cache.warn(
rank_zero_warn(
"There is a wandb run already in progress and newly created instances of `WandbLogger` will reuse"
" this run. If this is not desired, call `wandb.finish()` before instantiating `WandbLogger`."
)
Expand Down
4 changes: 2 additions & 2 deletions tests/loggers/test_wandb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ def test_wandb_logger_init(wandb):
# verify default resume value
assert logger._wandb_init["resume"] == "allow"

_ = logger.experiment
assert any("There is a wandb run already in progress" in w for w in pytorch_lightning.loggers.wandb.warning_cache)
with pytest.warns(UserWarning, match="There is a wandb run already in progress"):
_ = logger.experiment

logger.log_metrics({"acc": 1.0}, step=3)
wandb.init.assert_called_once()
Expand Down