Fix mypy for utilities.xla_device
#8755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancld
requested review from
Borda,
SeanNaren,
awaelchli,
carmocca,
justusschock,
kaushikb11,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #8755 +/- ##
======================================
Coverage 89% 89%
======================================
Files 169 169
Lines 14073 14074 +1
======================================
+ Hits 12466 12467 +1
Misses 1607 1607 |
awaelchli
approved these changes
Aug 5, 2021
carmocca
approved these changes
Aug 6, 2021
| _TORCHMETRICS_LOWER_THAN_0_3 = _compare_version("torchmetrics", operator.lt, "0.3.0") | ||
| _TORCHMETRICS_GREATER_EQUAL_0_3 = _compare_version("torchmetrics", operator.ge, "0.3.0") | ||
| _XLA_AVAILABLE = _module_available("torch_xla") | ||
| _XLA_AVAILABLE: bool = _module_available("torch_xla") |
Contributor
There was a problem hiding this comment.
Why is this necessary?
_module_available is annotated with -> bool
Contributor
Author
There was a problem hiding this comment.
Unfortunately, mypy is not able to figure that out without this explicit type hint.
Collaborator
There was a problem hiding this comment.
can confirm, we had the same problem in metrics:
https://github.com/PyTorchLightning/metrics/blob/525642df8c3f3f5f93cdd22b6b9cd802a3854634/torchmetrics/utilities/imports.py#L79-L80
SkafteNicki
approved these changes
Aug 6, 2021
four4fish
pushed a commit
to four4fish/pytorch-lightning
that referenced
this pull request
Aug 16, 2021
* Fix mypy for utilities.xla_device * Add explicit type hint for _XLA_AVAILABLE in utilities.imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #7037. This PR disentangles large #7218. It fixes mypy typing in
utilities.xla_device.py.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃