Skip to content

remove dead code in eval loop output tracking #8625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2021
Merged

remove dead code in eval loop output tracking #8625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a4f390
remove deadcode in eval loop
awaelchli Jul 29, 2021
1dc262e
fix type hint
awaelchli Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions pytorch_lightning/loops/epoch/evaluation_epoch_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,16 +240,10 @@ def _build_kwargs(self, batch: Any, batch_idx: int, dataloader_idx: int) -> Dict
return step_kwargs

def _track_output_for_epoch_end(
self,
outputs: List[Union[ResultCollection, Dict, Tensor]],
output: Optional[Union[ResultCollection, Dict, Tensor]],
) -> List[Union[ResultCollection, Dict, Tensor]]:
self, outputs: List[STEP_OUTPUT], output: Optional[STEP_OUTPUT]
) -> List[STEP_OUTPUT]:
if output is not None:
if isinstance(output, ResultCollection):
output = output.detach()
if self.trainer.move_metrics_to_cpu:
output = output.cpu()
elif isinstance(output, dict):
if isinstance(output, dict):
output = recursive_detach(output, to_cpu=self.trainer.move_metrics_to_cpu)
elif isinstance(output, Tensor) and output.is_cuda and self.trainer.move_metrics_to_cpu:
output = output.cpu()
Expand Down