Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 27, 2021

What does this PR do?

Also created a branch release/1.4.x

Before submitting

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the docs Documentation related label Jul 27, 2021
@awaelchli awaelchli added this to the v1.4.x milestone Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #8582 (f3377ea) into master (39de7fe) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8582   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         218     218           
  Lines       14411   14480   +69     
======================================
+ Hits        13307   13322   +15     
- Misses       1104    1158   +54     

@awaelchli awaelchli marked this pull request as ready for review July 27, 2021 16:19
@Borda Borda enabled auto-merge (squash) July 27, 2021 16:42
@mergify mergify bot added the ready PRs ready to be merged label Jul 27, 2021
@Borda Borda merged commit df16713 into master Jul 28, 2021
@Borda Borda deleted the feature/readme1.4 branch July 28, 2021 02:29
awaelchli added a commit that referenced this pull request Aug 3, 2021
awaelchli added a commit that referenced this pull request Aug 3, 2021
lexierule pushed a commit that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants