Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jul 26, 2021

What does this PR do?

adding validation for action YAMLs and fix them

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #8567 (8ccb0e4) into master (eaa16c7) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8567    +/-   ##
=======================================
+ Coverage      88%     92%    +4%     
=======================================
  Files         218     218            
  Lines       14405   14398     -7     
=======================================
+ Hits        12705   13296   +591     
+ Misses       1700    1102   -598     

Co-authored-by: Carlos Mocholí <[email protected]>
@Borda
Copy link
Collaborator Author

Borda commented Jul 27, 2021

@Borda Borda marked this pull request as ready for review July 27, 2021 11:32
@Borda Borda requested a review from tchaton as a code owner July 27, 2021 11:32
@mergify mergify bot added the ready PRs ready to be merged label Jul 27, 2021
@mergify mergify bot requested a review from a team July 27, 2021 11:32
@Borda Borda added bug Something isn't working ci Continuous Integration labels Jul 27, 2021
@Borda Borda added this to the v1.4.x milestone Jul 27, 2021
@Borda Borda changed the title CI: validate JSON CI: validate JSON & fix benchmark Jul 27, 2021
@Borda Borda added the priority: 1 Medium priority task label Jul 27, 2021
@Borda Borda merged commit 470842f into master Jul 28, 2021
@Borda Borda deleted the ci/json branch July 28, 2021 16:09
awaelchli pushed a commit that referenced this pull request Aug 3, 2021
* CI: validate JSON

* as GHA

* PT1.8

* 32g

Co-authored-by: Carlos Mocholí <[email protected]>
awaelchli pushed a commit that referenced this pull request Aug 3, 2021
* CI: validate JSON

* as GHA

* PT1.8

* 32g

Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Aug 3, 2021
* CI: validate JSON

* as GHA

* PT1.8

* 32g

Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants