Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jul 26, 2021

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #8566 (28447a8) into master (aadd2a9) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8566   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         218     218           
  Lines       14407   14407           
======================================
  Hits        13305   13305           
  Misses       1102    1102           

@Borda Borda requested a review from carmocca July 26, 2021 23:06
@Borda Borda marked this pull request as ready for review July 27, 2021 07:32
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Jul 27, 2021
@mergify mergify bot removed the has conflicts label Jul 28, 2021
@Borda Borda merged commit 0a71fe2 into master Jul 28, 2021
@Borda Borda deleted the ci/black branch July 28, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants